sort: propagate temporary file write errors - #14388
Open
tasodoufu wants to merge 1 commit into
Open
Conversation
|
GNU testsuite comparison: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14377.
Reproduction
When external sort spills a chunk to a temporary file, a write failure (for example,
ENOSPC/EFBIG) reachedwrite_lines, whosewrite_allcalls unconditionally usedunwrap(). The process therefore panicked instead of reporting the I/O error and exiting non-zero.Cause
The temporary-file chunk writer discarded the
io::Resultfrom both line and separator writes.Fix
Propagate write errors from
write_linesto the external-sort path with?, preserving the existing error handling and cleanup flow. Added a regression unit test using a writer that returnsStorageFull.Validation
cargo fmt --checkcargo test -p uu_sortcargo clippy -p uu_sort --all-targets -- -D warningsgit diff --checkThe focused test and full
uu_sortunit-test suite pass (29 tests).Not verified
A real full/size-limited filesystem was not mounted in this environment; the regression test deterministically exercises the same failing
Writepath.AI assistance was used to help inspect the issue and prepare this patch; the submitted change was reviewed and verified against the repository's contributing and AI-policy requirements.