stat . > /dev/full panics

[Devel08]

closes #10559

[github-actions]

GNU testsuite comparison:

Skip an intermittent issue tests/pr/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/tail-n0f (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/tail/follow-name (passes in this run but fails in the 'main' branch)
Congrats! The gnu test tests/expand/bounded-memory is now passing!
Congrats! The gnu test tests/rm/many-dir-entries-vs-OOM is now passing!

[xtqqczze]

We should emit an error message, to match GNU Coreutils

[Devel08]

well, we can do something like

            Token::Char(c) => {
                if let Err(e) = std::io::stdout().write_all(c.to_string().as_bytes()) {
                    show_error!("{}", strip_errno(&e));
                    std::process::exit(1);
                }
            }

but CONTRIBUTING.md says to avoid std::process::exit, however the output will be stat: No space left on device

[Devel08]

@cakebaker What do you think, is it safe to use std::process::exit here? Sorry for mention

[xtqqczze]

Would return Err(1); work?

[Devel08]

Nope, as it will print out the os error

[RenjiSann]

No, please refrain from using std::process::exit.
Instead, maybe you can propagate the error of write_all(() ?

[RenjiSann]

Nope, as it will print out the os error

Isn't it what we want to do ?

[Devel08]

Nope, as it will print out the os error

Isn't it what we want to do ?

Nope, that's what I did at first

[xtqqczze]

propagate the error of write_all(()

that would be ideal, but would require a much larger refactoring as uu_stat function result types generally use i32 instead of an actual error type.

[RenjiSann]

I guess we should go with a refactoring then, returning a simple i32 is not really rust-idiomatic.

[codspeed-hq]

Merging this PR will not alter performance

✅ 231 untouched benchmarks
⏩ 154 skipped benchmarks¹

---

_{Comparing Devel08:fix-issue-10559 (819b9eb) with main (ef50d8b)}

Footnotes

1. 154 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩