Skip to content

fix(docs): resolves nested variables fully when show vars is on(4247) - #67

Open
adwait-bruno wants to merge 1 commit into
usebruno:mainfrom
adwait-bruno:fix/nested-var-show-vars
Open

fix(docs): resolves nested variables fully when show vars is on(4247)#67
adwait-bruno wants to merge 1 commit into
usebruno:mainfrom
adwait-bruno:fix/nested-var-show-vars

Conversation

@adwait-bruno

Copy link
Copy Markdown
Contributor

REF:BRU-4247

On the Collection Docs Overview, a collection variable that points at another variable only resolved one level deep when Show vars was on. Hovering the same variable with Show vars off resolved it all the way The hover card goes through resolveValueDeep, which repeats substitution until nothing changes. Show vars went through resolveVariables, a single String.replace pass — and replace never re-scans the text it just inserted, so it stopped after the first hop.

Fix

Both call sites in useVariableResolver.tsx now use the looping resolver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant