fix(docs): resolves nested variables fully when show vars is on(4247) - #67
Open
adwait-bruno wants to merge 1 commit into
Open
fix(docs): resolves nested variables fully when show vars is on(4247)#67adwait-bruno wants to merge 1 commit into
adwait-bruno wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REF:BRU-4247
On the Collection Docs Overview, a collection variable that points at another variable only resolved one level deep when Show vars was on. Hovering the same variable with Show vars off resolved it all the way The hover card goes through
resolveValueDeep, which repeats substitution until nothing changes. Show vars went throughresolveVariables, a singleString.replacepass — andreplacenever re-scans the text it just inserted, so it stopped after the first hop.Fix
Both call sites in
useVariableResolver.tsxnow use the looping resolver