Skip to content

fixed sized Eigen vectors to fix crash at startup#66

Closed
enricocovili wants to merge 1 commit into
url-kaist:masterfrom
enricocovili:master
Closed

fixed sized Eigen vectors to fix crash at startup#66
enricocovili wants to merge 1 commit into
url-kaist:masterfrom
enricocovili:master

Conversation

@enricocovili

Copy link
Copy Markdown

This pull request refer to #62 as stated in the last message

@LimHyungTae

Copy link
Copy Markdown
Contributor

Solved by #81. PR is closed.

Thanks for raising the issue and pursuing the fix @enricocovili. We went with #72's approach (Vector3f for all three of normal_, singular_values_, pc_mean_) because singular_values_.minCoeff() is used as the flatness measure at cpp/patchworkpp/src/patchworkpp.cpp:221, which operates on the smallest of three singular values from JacobiSVD<MatrixX3f>Vector2f would have silently changed ground segmentation behavior.

@LimHyungTae LimHyungTae closed this May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants