Skip to content

Ruff formatted available radial space for #4383 #4423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmorris-uk wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ruff formatted available radial space for #4383 #4423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions process/models/stellarator/build.py
View file
Open in desktop

@timothy-nunn timothy-nunn Jul 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to clarify to anyone reviewing what was going on here. Before this change the calculation for available radial space was essentially:

data.build.available_radial_space = (
    data.stellarator.r_coil_minor * data.stellarator.f_coil_shape
    - data.physics.rminor
)

This bit of code was not doing anything and it was not changing the available_radial_space.

+data.stellarator_config.stella_config_derivative_min_lcfs_coils_dist * (
    data.physics.rminor
    - data.stellarator.f_st_rmajor * data.stellarator_config.stella_config_rminor_ref
)

It would be good for someone with stellarator knowledge to confirm that this was a mistake @jjwalkowiak @grmtrkngtn

Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,7 @@ def st_build(stellarator, f_output: bool, data: DataStructure):
data.build.available_radial_space = (
data.stellarator.r_coil_minor * data.stellarator.f_coil_shape
- data.physics.rminor
)
+data.stellarator_config.stella_config_derivative_min_lcfs_coils_dist * (
) + data.stellarator_config.stella_config_derivative_min_lcfs_coils_dist * (
data.physics.rminor
- data.stellarator.f_st_rmajor * data.stellarator_config.stella_config_rminor_ref
)
Expand Down
Loading