chore(lint): enable errcheck via golangci-lint#231
Merged
Conversation
xytan0056
force-pushed
the
chore/enable-errcheck
branch
5 times, most recently
from
July 22, 2026 09:10
2d0800c to
bc60000
Compare
sywhang
reviewed
Jul 22, 2026
| @echo " make test-integration - Run integration tests (slow)" | ||
| @echo " make bench - Run GetChangedTargets benchs (measurement only, not in CI)" | ||
| @echo " make bench - Run GetChangedTargets benchs (measurement only, not in CI)" | ||
| @echo " make lint - Run golangci-lint (errcheck)" |
Contributor
There was a problem hiding this comment.
Suggested change
| @echo " make lint - Run golangci-lint (errcheck)" | |
| @echo " make lint - Run golangci-lint" |
Contributor
|
might wanna rebase, there's some code changes that went into storage/disk |
xytan0056
commented
Jul 22, 2026
| ) | ||
|
|
||
| gomock( | ||
| name = "mock_sourcehasher", |
Contributor
Author
There was a problem hiding this comment.
inevitable, becuase errcheck needs source checked in to determine err handling
xytan0056
force-pushed
the
chore/enable-errcheck
branch
from
July 22, 2026 17:28
bc60000 to
d1986f4
Compare
sywhang
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.golangci.ymlwith errcheck enabled (production code only, tests excluded)os.RemoveAll,io.WriteString, andzap.Logger.Syncfrom errcheck — these are fire-and-forget by conventionmake linttargetMockSourceHashertest mock (migrated fromgithub.com/golang/mocktogo.uber.org/mock) because errcehck needs source to determine err handlingTest plan
CI