Conversation
xuwei-k
commented
Sep 10, 2026
xuwei-k
commented
Contributor
- Warn about dollars in names of definitions unless backticked scala/scala3#24690
xuwei-k
force-pushed
the
dollars-param-names
branch
from
September 10, 2026 00:54
d9b1d37 to
20c2150
Compare
xuwei-k
marked this pull request as draft
September 10, 2026 01:02
satorg
reviewed
Sep 10, 2026
Comment on lines
+185
to
+186
| def alignCombine(fa2: F[A])(implicit @deprecatedName(Symbol("ev$1"), "2.14.0") ev1: Semigroup[A]): F[A] = | ||
| typeClassInstance.alignCombine[A](self, fa2) |
Contributor
There was a problem hiding this comment.
I'm not sure if we really need this complexity in implicit parameter names – perhaps, we could simply change it to some "normal" names, e.g.:
def alignCombine(fa2: F[A])(implicit A: Semigroup[A]): F[A] =
typeClassInstance.alignCombine[A](self, fa2)
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.