Repository navigation
Make Hash platform independent. Always 8byte little endian #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,11 +20,11 @@ def taskdb_hash(url) | |
| end | ||
|
|
||
| def documentdb_hash(url) | ||
| SHA256_DIGEST.digest(url).unpack("L!")[0] | ||
| SHA256_DIGEST.digest(url).unpack("Q<")[0] | ||
| end | ||
|
|
||
| def autopingdb_hash(url) | ||
| SHA256_DIGEST.digest(url).unpack("q")[0] | ||
| SHA256_DIGEST.digest(url).unpack("q<")[0] | ||
| end | ||
|
Comment on lines
26
to
28
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't use this method anywhere, and the same with the Nothing we need to do here though, just thought I would mention it. |
||
| end | ||
| end | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will fix unless this PR is rejected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the README and matching spec descriptions to specify fixed 64-bit little-endian values, preserving signedness. Commit:
67897b1.