fix(solver): nearest netlabel slide + penalize trace crossings (#2554, #2552)#574
Open
rovidev95 wants to merge 2 commits into
Open
fix(solver): nearest netlabel slide + penalize trace crossings (#2554, #2552)#574rovidev95 wants to merge 2 commits into
rovidev95 wants to merge 2 commits into
Conversation
- #2554: sort trace-anchored netlabel overlap candidates by distanceFromOriginal so y+/y- labels stay near their anchor. - #2552: explore collision-free routes and pick the path with the fewest crossings against already-routed traces, then shortest length. Adds unit tests for orthogonal crossing detection. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Jul 2, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses tscircuit/core#2554 and tscircuit/core#2552.
#2554 — net labels (y+/y-) slide too far
TraceAnchoredNetLabelOverlapSolvernow sorts overlap-resolution candidates bydistanceFromOriginalascending, so the first valid candidate keeps power/ground labels closest to their anchor.#2552 — trace crossings not penalized
SchematicTraceSingleLineSolver2explores the BFS queue until empty, scores each collision-free path ascrossings * 1000 + pathLength, and picks the best.SchematicTraceLinesSolverpasses already-routed paths asexistingTracePaths.Tests
/attempt #2554
/attempt #2552