fix: merge same-net trace lines close together (#34)#573
Open
yanyishuai wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
yanyishuai
force-pushed
the
fix/issue-34-merge-same-net-traces
branch
from
849f69a to
c464393
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #34 — merge same-net trace segments that are nearly collinear (same X or Y within tolerance) into aligned straight runs.
Changes
mergeNearbySameNetTraceSegmentspost-processing inTraceCleanupSolverexample02with before/after site pageRepro / before-after
tests/repros/repro34-merge-same-net-traces.test.tssite/repros/repro34-merge-same-net-traces.page.tsx(red = before, green = after)Test plan
bun test tests/solvers/TraceCleanupSolver/mergeNearbySameNetTraceSegments.test.tsbun test tests/repros/repro34-merge-same-net-traces.test.tsbunx tsc --noEmitWallet
Do4v7foHJvRJLpRRoGaVPWX6DDEjX3yTK7J91gpwUQpE/claim #34
Closes #34