Repository navigation
Add angleplate mounting contract from roadmap item 0176 - #120
Open
proofline-studio wants to merge 1 commit into
Open
proofline-studio wants to merge 1 commit into
proofline-studio wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the right-angle mounting plate parameter contract requested in #13, item 0176. The exact roadmap string currently throws
Unsupported modelprinter function "angleplate"; it now resolves through the public modelprinter registry to validated millimeter dimensions and six through-hole centers.The contract fixes the requested four-base/two-face hole topology, defines the coordinate frame and inside-corner radius, and rejects duplicate tokens, unknown or missing dimensions, unsupported counts, nonfinite geometry, and holes that touch an edge or one another. The base grid is centered on the straight base after the upright and fillet, so the example retains material around all six bores. Registration follows folder discovery without changing generated files or existing models.
Validation: the exact string fails on pinned upstream
0f3582ac55138e3eb5d27404a728e6cd4ce3a114; the four new contract tests pass 38 assertions.bun teston native Linux with Bun 1.4.3: 311 tests pass, 5,873 assertions.bun run typecheck: passes.bun run format:check: passes.bun run build: passes.This is modelprinter's parser/schema/dimensions scope, as specified in AGENTS.md. Geometry and visual snapshots belong in jscad-electronics. Prepared with AI assistance and tested on the environments above. Related to #13; does not close the 996-item roadmap.