Repository navigation
fix: align NEMA23 body and curved rear cap with rectangular rear pattern - #119
Merged
Merged
Conversation
|
Thank you for your contribution! 🎉 PR Rating: ⭐ Track your contributions and see the leaderboard at: tscircuit Contribution Tracker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NEMA23 rear previously reused the front flange's nearly square outline and square fastener pattern. Define a curved rear cap with a 50 × 32 mm rectangular rear pattern, R5 concave recesses, and R2.5 outer fillets. The default body now follows that same curved outline, so the rear shoulders do not protrude beyond an octagonal body. The front flange, mounting holes, pilot, shaft, and body envelope remain unchanged.
Paired renderer: tscircuit/jscad-electronics#503
Add independent rear X/Y spacing, rear profile selectors, and configurable body/rear arc radii. Existing scalar rear spacing still sets both axes. Keep the former body and rear depiction available with
nema23_chamfered_backholespacing47.14mm_backscrewm4. Other frame defaults retain their current shapes.Validate rear bores and screw heads against the actual straight edges and curved shoulders, and validate the entire front through-hole radius against the body profile. Wire references follow the selected outline. The shared analytic checks do not introduce renderer dependencies.
The rear profile and pattern use STEPPERONLINE's ST-M10 rear-adapter drawing as a representative reference. The motor retains its 56.4 mm envelope and uses illustrative M3 socket screws. That adapter drawing does not establish exact motor threads, screw style, or rear-cover radii; these defaults are not universal NEMA23 dimensions. Matching body/rear shoulders follows the motor-photo reference.
Validation with Bun 1.4.3: all 307 tests, type checking, formatting, and package build passed. Tests cover schema roundtrips, default/legacy selections, independent dimensions and radii, full-circle clearance, and diagonal wire references. Visual snapshots and geometry validation belong in the paired renderer PR.