Skip to content

Forward schematic pin-label font size to Circuit JSON - #3430

Merged
mohan-bee merged 2 commits into
tscircuit:mainfrom
GokulPandi-M:codex/forward-pin-label-font-size
Aug 26, 2026
Merged

Forward schematic pin-label font size to Circuit JSON#3430
mohan-bee merged 2 commits into
tscircuit:mainfrom
GokulPandi-M:codex/forward-pin-label-font-size

Conversation

@GokulPandi-M

@GokulPandi-M GokulPandi-M commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Carries the optional per-port schPinLabelFontSize prop into schematic_port.display_pin_label_font_size as a precise numeric Circuit JSON value.

Core resolves:

  • "sm" to 0.12
  • numeric distance inputs such as "0.1mm" (already normalized by props) to 0.1
  • "default" and omitted values to undefined, preserving the existing context-sensitive renderer default

Dependencies

Scope

This PR only resolves the props-level input and writes the precise optional value into Circuit JSON. Renderer support belongs in a separate circuit-to-svg PR.

Validation

  • focused regression test passes
  • full TypeScript check passes
  • package build passes
  • distribution smoke test passes
  • changed files pass Biome formatting

@vercel

vercel Bot commented Aug 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview Aug 25, 2026 9:58pm

Request Review

@GokulPandi-M
GokulPandi-M marked this pull request as ready for review August 25, 2026 19:08
@seveibar

Copy link
Copy Markdown
Contributor

don't submit for review until CI passes!

@GokulPandi-M

GokulPandi-M commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

don't submit for review until CI passes!

yeap !! but this pr denpends on tscircuit/circuit-json#723 (so it is failing btw sorry for confusions)

@GokulPandi-M
GokulPandi-M requested a review from seveibar August 25, 2026 19:22
@mohan-bee
mohan-bee merged commit fd00785 into tscircuit:main Aug 26, 2026
26 of 27 checks passed
@tscircuitbot

Copy link
Copy Markdown
Contributor

Thank you for your contribution! 🎉

PR Rating: ⭐⭐
Impact: Minor

Track your contributions and see the leaderboard at: tscircuit Contribution Tracker


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants