Test fanout-solver #90 in Core - #3404
Open
ShiboSoftwareDev wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@tscircuit/fanout-solver@0.0.35dependency with the exact head commit of Reuse preloaded fanout trace identities fanout-solver#905011b76e9c724c747037e0b47a94fde64dd04860Why this is needed
fanout-solver#90 stops preloaded fanout traces from being returned again as newly emitted copper. The solver-level regression passes, but Core is the phased host that accumulates
fanoutTraces, converts them into Circuit JSON, and exercises the wider breakout/fanout matrix. Pinning the exact PR head lets Core's full type-check, test shards, smoke test, and snapshots reveal integration regressions before the solver PR is merged or published.This is a temporary integration-test pin. After #90 is merged and released, Core should return to an exact published version.
Core CI result
✅ The exact #90 head passes Core type-check, smoke test, formatting, and all ten test shards. No Core snapshot regression was reported.
Local verification
bunx tsc --noEmittests/repros/repro-am62l-lpddr4-two-bus-fanout.test.tsxtests/breakout/breakout-insufficient-fanout-space-error.test.tsxpassed when rerun alone after timing out only while both large dependency suites were competing for local CPUgit diff --checkUpstream solver PR: tscircuit/fanout-solver#90