Test fanout-solver #85 in Core - #3403
Open
ShiboSoftwareDev wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@tscircuit/fanout-solver@0.0.35dependency with the exact head commit of Preserve source-trace identity in fanout output fanout-solver#85599f24d0a9d7b9270fddbaf2b46899e6cdef7b6fWhy this is needed
fanout-solver#85 preserves persistent
source_trace_idmetadata on emitted fanout copper. Core relies on that identity across fanout and global routing phases, so the solver's own tests are not enough to establish integration safety. Pinning the exact PR head lets Core's full type-check, test shards, smoke test, and snapshots show whether the new output shape fixes the handoff without changing existing routes.The current #85 head declares solver version
0.0.33, while Core main normally pins published0.0.35. This PR intentionally tests the exact requested PR head, but failures or snapshot changes must therefore be checked for branch drift as well as the identity change. #85 should be rebased onto current fanout-solver main before being treated as release-ready.This is a temporary integration-test pin. After #85 is rebased, merged, and released, Core should return to an exact published version.
Core CI result
✅ The exact #85 head passes Core type-check, smoke test, formatting, and all ten test shards. No Core snapshot regression was reported despite the older branch base noted above.
Local verification
bunx tsc --noEmittests/repros/repro-am62l-lpddr4-two-bus-fanout.test.tsxtests/breakout/breakout-insufficient-fanout-space-error.test.tsxpassed when rerun alone after timing out only while both large dependency suites were competing for local CPUgit diff --checkUpstream solver PR: tscircuit/fanout-solver#85