Repro: maxViaCount is dropped from autorouter input - #3363
Open
MustafaMulla29 wants to merge 8 commits into
Open
Repro: maxViaCount is dropped from autorouter input#3363MustafaMulla29 wants to merge 8 commits into
MustafaMulla29 wants to merge 8 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
MustafaMulla29
marked this pull request as ready for review
August 21, 2026 15:44
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/repros/repro-rp2040-crystal-max-via-count.test.tsx; the existing primitivetrace-max-via-counttest remains unchangedXIN,XOUT,CXIN, andCXOUTreceivesource_trace.max_via_count: 0from the four-pin crystalPCB trace uses 2 vias, exceeding the 0 maximumtest.failing, so this PR contains only the regression reproductionWhy this matters
The crystal applies a zero-via constraint to its XIN/XOUT signals. Core preserves it as
source_trace.max_via_countbut drops it while creating the autorouter input. The default autorouter therefore chooses a legal two-via path without knowing that vias are forbidden, and DRC reports the violation only after routing.Testing
bun test tests/components/primitive-components/trace-max-via-count.test.tsx tests/repros/repro-rp2040-crystal-max-via-count.test.tsxbunx biome check tests/components/primitive-components/trace-max-via-count.test.tsx tests/repros/repro-rp2040-crystal-max-via-count.test.tsxRelated