Fix native macOS termination handling - #654
Merged
Merged
Conversation
johanntan
marked this pull request as ready for review
August 18, 2026 14:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppEvents::on_should_terminateRoot cause
wxWidgets checks whether a macOS application may terminate by sending a vetoable close event to its top window. Paperback treated every vetoable macOS close as an ordinary window close, vetoed it, and hid the frame. This also cancelled shutdown/restart and Quit requests sent from the Dock or Application Switcher.
Current wxDragon
mainexposesOSXOnShouldTerminatethroughon_should_terminate, allowing Paperback to distinguish application termination without relying on Cocoa internals.Validation
cargo +nightly fmt --checkcargo build -p paperbackcargo check -p paperback --lockedcargo test -p paperback(40 passed)