Repository navigation
Stop speech when touch focuses an item, with Stop speech when touching the screen off - #285
Merged
Merged
Conversation
The Wear material colors pointed at the system's dynamic colors, which only exist from Android 12, and the watch's values-watch-v30 copy applied them on Wear OS 3 too, where the training list items that use them could fail to load. The base colors are now close fixed colors, and values-v31 uses the dynamic ones. Without the watch override, Android 12 and later watches still get the dynamic colors, since a watch qualifier would outrank values-v31.
…g the screen off With the switch off, touching no longer stopped speech, and focusing an item by touch only interrupted speech that new speech can interrupt. Notifications, toasts and other uninterruptible speech went on, and the touched item waited behind them, so exploring seemed slow and silent. Now focusing an item by touch stops all speech, as touching did with the switch on. Fixes #282
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #282
Problem
With Stop speech when touching the screen off, touching the screen and moving onto an item no longer stop speech, as intended. But the touched item's speech then only interrupts speech that new speech can interrupt. Notifications, toasts and other announcements are spoken with
QUEUE_MODE_UNINTERRUPTIBLE_BY_NEW_SPEECH, and with the switch on, the gentle interrupt on touch is what cut them off. With the switch off they went on, and the touched item waited behind them, so exploring by touch seemed slow and gave no feedback.Change
In
FocusFeedbackMapper, with the switch off, the feedback that focuses an item by touch (TOUCH_UNFOCUSED_NODEandTOUCH_FOCUSED_NODE) now carries the same gentle interrupt that touching carries with the switch on. Speech goes on while the finger is down, and stops when touch focuses an item, as the setting's translator comment describes. With the switch on, nothing changes.Testing
FocusFeedbackMapperTouchTestchecks which touch actions interrupt, with the switch on and off.:talkback:testPhoneDebugUnitTest,:lintPhoneDebugand:lintWearDebugpass.