Repository navigation
Add an audio output device reading control - #284
Merged
Merged
Conversation
…the setting The reading control only knew the chosen output when the stored value matched exactly, so a device whose type had changed, or Any external device, sent the first swipe back to the start of the list. Both now use indexOfOption, which matches a device by name and any external device to the first one. Also documents the reading control and tests the matching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #263
Adds an "Audio output device" reading control that cycles system default, phone
speaker, and each connected external device, so the playing device can be
switched quickly without opening settings.
The control writes the existing audio output device preference, so routing and
the Sound and vibration setting stay in sync. The device list is shared between
the settings dialog and the control by factoring it out of
AudioDeviceRouter.updatePreferenceintoAudioDeviceRouter.getOutputOptions.The control is off by default, under Settings > Reading controls.