Repository navigation
Clean up unused and duplicate resources - #278
Merged
Merged
Conversation
Lint reported 26 unused resources. This removes 22 of them and their translations: strings and arrays left from features Backtalk dropped, such as the Play Store entry, the TalkBack updated notification and the reading control added dialogs, and an unused dialog layout. Kept: show_play_store, which overlayable.xml declares, the phonetic letters strings, which the watch settings use, and pref_speech_control_key, which SpeechControl.kt names.
…ch the root declares
… the English 119 zh-rCN entries repeated resources marked translatable="false" with the same value, such as key commands, preference values and symbols, so they changed nothing and lint warned about each. The zh-rCN entries that differ, such as braille display key names in Chinese, are kept.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes about half of the lint warnings that aren't in the baseline (380 to 191). Resources only, no code changes.
preference_dialog_edittextlayout. Four are kept:show_play_store, whichoverlayable.xmldeclares; the phonetic letters title and summary, which the watch settings use; andpref_speech_control_key, whichSpeechControl.ktnames. I checked the removed names against code, XML, andgetIdentifierlookups.xmlns:xliffdeclaration repeated on 49 strings invalues-pl/strings_backtalk.xml. The root element already declares it.translatable="false"resources that are identical to the English value, such as key command letters, preference values and symbols. They changed nothing at runtime. The 140 zh-rCN entries that do differ, mostly braille display key names translated into Chinese, are kept, because removing them would show Chinese users English.:lintPhoneDebug,assembleDebugand:talkback:testPhoneDebugUnitTestpass.