Workspace: restore saved display layout by default#539
Open
armm77 wants to merge 1 commit into
Open
Conversation
The resolution chosen in Preferences->Display was correctly written to ~/Library/Preferences/.NextSpace/Displays-<hash>.config, but it was never reapplied on login. Workspace_main gated the restore on [defs boolForKey:@"RestoreDisplayLayout"] != NO, and since boolForKey: returns NO for an absent key, the condition was always false — the key is not set in any default config, so the layout was never restored and the display reverted to the X/RandR default after every reboot. Treat a missing RestoreDisplayLayout key as YES, so the saved layout is restored unless the user explicitly disables it. Also ship the key in the skel Workspace defaults for discoverability on new installs. Restoring is safe: applyDisplayLayout: validates the layout first, and a hardware change yields a different config hash that falls back to the default layout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The resolution chosen in Preferences->Display was correctly written to ~/Library/Preferences/.NextSpace/Displays-.config, but it was never reapplied on login. Workspace_main gated the restore on [defs boolForKey:@"RestoreDisplayLayout"] != NO, and since boolForKey: returns NO for an absent key, the condition was always false — the key is not set in any default config, so the layout was never restored and the display reverted to the X/RandR default after every reboot.
Treat a missing RestoreDisplayLayout key as YES, so the saved layout is restored unless the user explicitly disables it. Also ship the key in the skel Workspace defaults for discoverability on new installs. Restoring is safe: applyDisplayLayout: validates the layout first, and a hardware change yields a different config hash that falls back to the default layout.