Add TrueFoundryAgentStore for agents - #560
Merged
Merged
Conversation
bhaveshpatel640
requested review from
chiragjn,
debajyoti-truefoundry,
heerambavi1998,
sr07asthana and
thesujai
as code owners
September 2, 2026 19:22
🦋 Changeset detectedLatest commit: 8060262 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
bhaveshpatel640
marked this pull request as draft
September 2, 2026 19:22
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
bhaveshpatel640
marked this pull request as ready for review
September 2, 2026 19:52
bhaveshpatel640
marked this pull request as draft
September 2, 2026 19:52
bhaveshpatel640
force-pushed
the
AGE-2064
branch
from
September 3, 2026 05:57
1a5b818 to
45b8a9e
Compare
bhaveshpatel640
force-pushed
the
AGE-2064
branch
from
September 3, 2026 06:05
45b8a9e to
72c6a3f
Compare
bhaveshpatel640
marked this pull request as ready for review
September 3, 2026 06:06
bhaveshpatel640
marked this pull request as draft
September 3, 2026 06:06
bhaveshpatel640
force-pushed
the
AGE-2064
branch
from
September 3, 2026 07:34
45b880d to
2dcbc86
Compare
bhaveshpatel640
changed the title
bhaveshpatel640
marked this pull request as ready for review
September 3, 2026 08:33
bhaveshpatel640
force-pushed
the
AGE-2064
branch
from
September 3, 2026 08:44
4af175c to
c9270c5
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
debajyoti-truefoundry
approved these changes
Sep 3, 2026
…n from main. TrueFoundry mode cannot run with STANDALONE=true.
bhaveshpatel640
force-pushed
the
AGE-2064
branch
from
September 3, 2026 16:51
5b5713f to
31377ea
Compare
bhaveshpatel640
force-pushed
the
AGE-2064
branch
2 times, most recently
from
September 3, 2026 17:09
f85a757 to
ac37e94
Compare
bhaveshpatel640
force-pushed
the
AGE-2064
branch
from
September 3, 2026 17:15
ac37e94 to
48f409f
Compare
bhaveshpatel640
force-pushed
the
AGE-2064
branch
from
September 3, 2026 17:32
48f409f to
99bf0fc
Compare
bhaveshpatel640
force-pushed
the
AGE-2064
branch
from
September 3, 2026 17:42
99bf0fc to
8060262
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8060262. Configure here.
| return row === undefined ? undefined : toRecord(row); | ||
| } | ||
|
|
||
| withTransaction<T>(fn: (transaction: Transaction<Database>) => Promise<T>): Promise<T> { |
Contributor
There was a problem hiding this comment.
Why do we need this? Why can't we take db as an argument in the TrueFoundryAgentStore Constructor?
|
|
||
| async createAgent(input: CreateAgentInput, transaction?: TTransaction): Promise<AgentRecord> { | ||
| // Lets the DB unique constraint pick one winner for this tenant ID and name. | ||
| // Prevents concurrent requests from both creating the same remote agent. |
Contributor
There was a problem hiding this comment.
This is only true if transaction is present. I do not see any code validating that. The type allows undefined.
| return this.#inner.updateAgent(input, transaction); | ||
| } | ||
|
|
||
| return this.#withUpdateLock(input, transaction, async txn => { |
Contributor
There was a problem hiding this comment.
Please ensure we validate that the transaction is actually present here and is not undefined or absent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wire agent create/update/delete to ServiceFoundry in TrueFoundry mode via
TrueFoundryAgentStore(SF-first, remote id inexternal_id). Standalone stays DB-only.Linear: AGE-2064
Changes
TrueFoundryAgentStore+putRemoteAgent/deleteRemoteAgent/toPutRemoteAgentPayloadresolveAgentStore(same pattern as models/MCP)map*/to*convention insrc/truefoundry/AGENTS.mdHow was this tested?
tests/unit/truefoundry/TrueFoundryAgentStore.test.ts(create/update/delete + failure paths)resolveAgentStoretsc --noEmitfor@truefoundry/trueforgeChecklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changed (N/A — no new env;AGENTS.mdmapper convention only)Note
Medium Risk
Agent CRUD now coordinates local Postgres with ServiceFoundry; partial failures rely on cleanup/restore logic, though standalone mode is unchanged.
Overview
In TrueFoundry mode, agent create/update/delete now goes through
TrueFoundryAgentStore, which keeps the local DB as source of truth but mirrors changes to ServiceFoundry (PUT/DELETEon/internal/tfg/agents) and persists the returnedagentIdinexternal_id. Create/update use transactional advisory locks and rollback paths when remote or local writes fail.Wiring matches models/MCP: a shared
TrueFoundryServiceFoundryServerClient(with separate 10s default vs 3s agent CRUD timeouts) and per-requestresolveAgentStoreso HTTP handlers use the token-bound decorator while the scheduler stays on DB-only persistence.listAgentsnow accepts an optionalexternal_idsfilter (store contract + Postgres/SQLite). Agent create rejects reserved namestfgandtrueforge, andAgentExternalIdConflictErrormaps to 409 alongside name conflicts.Reviewed by Cursor Bugbot for commit 8060262. Bugbot is set up for automated code reviews on this repo. Configure here.