chore: standardize button and icon button primitives - #537
Open
harshil-2096 wants to merge 3 commits into
Open
Conversation
…y, ghost, and destructive variants
harshil-2096
requested review from
govindavashishtha,
kumarsks619,
qaifi-tf,
sajal-truefoundry,
sayan-truefoundry and
vinit-truefoundry
as code owners
September 1, 2026 12:33
🦋 Changeset detectedLatest commit: c59ea8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 04f194f. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Medium Risk
Large, UI-wide refactor with a breaking public Button/IconButton contract for package consumers; behavior should be equivalent but visual edge cases are possible where custom classNames replaced old
iconsizing.Overview
Introduces a public compound API for
ButtonandIconButtonin@truefoundry/trueforge-ui: callers must useButton.Primary,.Secondary,.Ghost, or.Destructive(and matchingIconButton.*) instead of a single<Button variant="…" />. Sizes are renamed tosmall,medium, andlarge; icon-only controls rely onsize="small"plusaspect-square/px-0overrides where needed.The
auiButtonClasshelper is removed; styling lives in the primitives. Every in-package usage (atoms, layouts, settings, composer, tool approval, etc.) is migrated to the new API.outline/defaultvariants are folded into Primary or Secondary as appropriate.Docs, README exports table, changeset (minor), and tests are updated—including compound variant coverage and a reasoning-effort selector assertion for selected-option hover styling.
Reviewed by Cursor Bugbot for commit c59ea8e. Bugbot is set up for automated code reviews on this repo. Configure here.