Add agent session metrics - #532
Merged
Merged
Conversation
…ove session state management. Update AgentSessionsFilters to load all agents in pagination. Adjust matchLocation function to accept an object for better readability. Add tests for AgentSessionsFilters and enhance existing tests for AgentDetailsPage and ThreadListContainer.
- Introduced a new agent metrics tab with features like aggregate cards, time-range filtering, and line charts in the trueforge-ui package. - Enhanced various components and types to support the new metrics functionality, including AgentMetrics, AgentMetricsView, and AgentMetricChart. - Updated README and API documentation to reflect the new metrics features and components.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
harshil-2096
requested review from
bhaveshpatel640,
chiragjn,
debajyoti-truefoundry,
govindavashishtha,
heerambavi1998,
kumarsks619,
qaifi-tf,
sajal-truefoundry,
sayan-truefoundry,
sr07asthana,
thesujai and
vinit-truefoundry
as code owners
September 1, 2026 09:24
🦋 Changeset detectedLatest commit: 13aa9dd The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 454f216. Configure here.
harshil-2096
marked this pull request as draft
September 1, 2026 09:30
harshil-2096
marked this pull request as ready for review
September 1, 2026 10:46
govindavashishtha
enabled auto-merge (squash)
September 2, 2026 06:37
Contributor
|
Need to standardise the colors here @harshil-2096, merging for now. Please make a followup PR |
govindavashishtha
approved these changes
Sep 2, 2026
govindavashishtha
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
How was this tested?
Checklist
pnpm build,pnpm test,pnpm typecheck,pnpm lint:ci, andpnpm format:checkpass locallypackages/trueforge-sdk,.github/fern/openapi/openapi.json,docs/openapi.json) — fork PRs omit SDK regen; maintainers regenerate after merge.env.exampleupdated if configuration or behavior changedNote
Medium Risk
New optional server contract and internal metrics API dependency; chart loading issues N+1 requests per definition on range change, but changes are gated behind the metrics port and mostly additive UI.
Overview
Adds an optional Metrics tab on library agent details (
?tab=metrics), shown only whenAgentUIServerexposes the newmetricsport (getCharts,getMeters,getChartData). The tab is built from overridable slots (AgentMetrics,AgentMetricsView, aggregate cards, Chart.js line charts, and a preset time-range filter that reusesAgentSessionsFilters).AgentMetricsContainerloads chart definitions once, then fetches meters and per-chart series for the selected agent and time window (default last 24h). The TrueForge Harness adapter wires this toclient.internal.metrics; local dev proxies/internalto the server alongside/api. Session list rows now surface real session metrics from the API instead of zeros.Also exports hooks (
useAgentMetricsServer/useOptionalAgentMetricsServer), documents the port and slots, bumps@truefoundry/assistant-ui-runtimeto 0.1.23, and closes the drawer threads panel when library/sessions overlays open.Reviewed by Cursor Bugbot for commit 13aa9dd. Bugbot is set up for automated code reviews on this repo. Configure here.