Skip to content

fix(test): stabilize unit test fixtures - #7060

Merged
kuny0707 merged 1 commit into
tronprotocol:release_v4.8.3from
317787106:fix/ci-test-fixtures
Oct 23, 2026
Merged

kuny0707 merged 1 commit into
tronprotocol:release_v4.8.3from
317787106:fix/ci-test-fixtures

Conversation

@317787106

@317787106 317787106 commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

What does this PR do?

Fixes three shared test-fixture issues:

  • AccountIdIndexStoreTest: replace random account-ID bytes with five distinct ASCII IDs that remain distinct after UTF-8 decoding and lowercase normalization.
  • RelayServiceTest.testStrictHelloAuthentication: populate the genesis, solid and head block hashes so the HELLO fixture passes structural validation and reaches the authentication assertions.
  • TransactionsMsgHandlerTest: inject a mocked FetchBlockService into the standalone AdvService used by the disconnect-recovery fixture, including testInvalidSignatureDisconnectWaitsForBusyAnnouncer.

Why are these changes required?

Avoid random account-ID key collisions and complete the fixtures needed for authentication and disconnect-recovery tests.

This PR has been tested by:

All 40 tests across the three classes passed on ARM64 / JDK 17. CI-scoped Checkstyle and git diff --check passed.

Follow up

None.

Extra details

Test fixtures only.

@github-actions
github-actions Bot requested review from bladehan1 and lxcmyf October 23, 2026 13:28
@317787106 317787106 changed the title fix(test): fix 3 test cases fix(test): stabilize unit test fixtures Oct 23, 2026
@kuny0707
kuny0707 merged commit 989f3db into tronprotocol:release_v4.8.3 Oct 23, 2026
19 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants