Skip to content

fix(webapp): pin fast-xml-parser past the 5.7 irsa break - #4960

Closed
ArjunCodess wants to merge 2 commits into
triggerdotdev:mainfrom
ArjunCodess:fix/fast-xml-parser-override
Closed

ArjunCodess wants to merge 2 commits into
triggerdotdev:mainfrom
ArjunCodess:fix/fast-xml-parser-override

Conversation

@ArjunCodess

Copy link
Copy Markdown

Summary

  • pin fast-xml-parser 5.x past 5.7.0–5.7.1 so @aws-sdk/xml-builder's addEntity("#xD") no longer throws during STS IRSA credential resolution
  • add a webapp unit test that the override is in place and that those character-reference entities parse

Fixes #4951

Test plan

  • pnpm --filter webapp test -- apps/webapp/test/fastXmlParserAwsEntities.test.ts
  • confirm pnpm why fast-xml-parser no longer resolves 5.7.0 or 5.7.1
  • on a self-hosted EKS webapp with IRSA, magic-link / SES send succeeds

@changeset-bot

changeset-bot Bot commented Sep 20, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 992e032

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

Copy link
Copy Markdown
Contributor

Hi @ArjunCodess, thanks for your interest in contributing!

This project requires that pull request authors are vouched, and you are not in the list of vouched users.

This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details.

@github-actions github-actions Bot closed this Sep 20, 2026
@coderabbitai

coderabbitai Bot commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: ee7f738b-b04c-432f-859d-79bc37704018

📥 Commits

Reviewing files that changed from the base of the PR and between 3dcafbd and 992e032.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • .server-changes/irsa-xml-parser-pin.md
  • apps/webapp/test/fastXmlParserAwsEntities.test.ts
  • package.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 potential issue.

Devin Review

});

it("accepts the character-reference entities @aws-sdk/xml-builder registers", async () => {
const { XMLParser } = await import("fast-xml-parser");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 Unnecessary dynamic import

fast-xml-parser loads unconditionally, so await import() lacks a permitted use case. Repository guidance requires a static import here.

Devin Review


Was this helpful? React with 👍 or 👎 to provide feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: self-hosted webapp cannot obtain IRSA credentials — fast-xml-parser 5.7.x rejects @aws-sdk/xml-builder's addEntity("#xD")

1 participant