fix(build): support decorator metadata with TypeScript 7 - #4505
Merged
carderne merged 5 commits intoAug 5, 2026
Merged
Conversation
|
| Name | Type |
|---|---|
| trigger.dev | Patch |
| @trigger.dev/build | Patch |
| @trigger.dev/core | Patch |
| @trigger.dev/python | Patch |
| @trigger.dev/react-hooks | Patch |
| @trigger.dev/redis-worker | Patch |
| @trigger.dev/rsc | Patch |
| @trigger.dev/schema-to-json | Patch |
| @trigger.dev/sdk | Patch |
| @internal/dashboard-agent | Patch |
| @internal/cache | Patch |
| @internal/clickhouse | Patch |
| @internal/llm-model-catalog | Patch |
| @internal/metrics-pipeline | Patch |
| @trigger.dev/rbac | Patch |
| @internal/redis | Patch |
| @internal/replication | Patch |
| @internal/run-engine | Patch |
| @internal/run-store | Patch |
| @internal/schedule-engine | Patch |
| @trigger.dev/sso | Patch |
| @internal/testcontainers | Patch |
| @internal/tracing | Patch |
| @internal/tsql | Patch |
| @internal/sdk-compat-tests | Patch |
| @trigger.dev/database | Patch |
| @trigger.dev/otlp-importer | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📜 Recent review details⏰ Context from checks skipped due to timeout. (32)
WalkthroughThe build package now loads TypeScript dynamically and supports TypeScript 7 through the optional 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@trigger.dev/build
trigger.dev
@trigger.dev/core
@trigger.dev/python
@trigger.dev/react-hooks
@trigger.dev/redis-worker
@trigger.dev/rsc
@trigger.dev/schema-to-json
@trigger.dev/sdk
commit: |
carderne
force-pushed
the
feature/tri-12948-support-emitdecoratormetadata-with-typescript-7
branch
from
August 5, 2026 08:50
31e8cc5 to
bc095a4
Compare
carderne
marked this pull request as ready for review
August 5, 2026 09:00
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ericallam
approved these changes
Aug 5, 2026
carderne
force-pushed
the
feature/tri-12948-support-emitdecoratormetadata-with-typescript-7
branch
from
August 5, 2026 14:49
87ed753 to
9b50bd2
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
carderne
deleted the
feature/tri-12948-support-emitdecoratormetadata-with-typescript-7
branch
August 5, 2026 15:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow projects using TypeScript 7 to enable
emitDecoratorMetadata()without adding the TypeScript 6 compiler to every Trigger.dev CLI installation. Addresses #4500.Fix
The extension now resolves TypeScript from the project and feature-detects the legacy compiler API. TypeScript 5 and 6 continue using the project's compiler, while TypeScript 7 projects can install Microsoft's optional
@typescript/typescript6compatibility package alongside TypeScript 7.When no compatible compiler API is available, the build reports an actionable installation error. The extension documentation includes setup commands for npm, pnpm, and Bun.
Verified with TypeScript 5, TypeScript 6, TypeScript 7 with and without the compatibility package, emitted decorator metadata, packed ESM and CommonJS consumers, package export checks, and typechecking.