-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(run-engine): fair virtual-time scheduling for the concurrency-key dequeue #4367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
1stvamp
wants to merge
28
commits into
main
Choose a base branch
from
feat/ck-virtual-time-scheduling
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
4121c68
feat(run-engine): concurrency-key virtual-time key builders
1stvamp fa5c7ce
feat(run-engine): ckVirtualTimeScheduling options flag
1stvamp d45ae0c
feat(run-engine): two-pass virtual-time CK dequeue command
1stvamp 962cfa2
feat(run-engine): register CK variants in vtime index on enqueue
1stvamp f9f6705
feat(run-engine): re-register CK variants in vtime index on nack
1stvamp 6b41b7e
test(run-engine): fairness scenarios on the real batched dequeue path
1stvamp 6d45d86
test(run-engine): multi-consumer correctness + op-count budget
1stvamp f50bb99
test(run-engine): default-off regression proof
1stvamp e916bb7
feat(run-engine,webapp): wire ckVirtualTimeScheduling env flag (code-…
1stvamp d06ddfa
chore(run-engine): ship note + comment/format cleanup
1stvamp 2d514c4
fix(run-engine,webapp): address whole-branch adversarial review
1stvamp 56ece4a
docs(run-engine): record CK vtime known limitations for GA decision
1stvamp 660f342
docs(run-engine): plan + references for virtual-time CK fair scheduling
1stvamp 166cfc0
docs(run-engine): add fairness explainer diagrams
1stvamp 4e77219
fix(run-engine): move design docs out of the Mintlify docs/ tree; format
1stvamp eb3c599
docs(run-engine): tighten CK fairness server-changes note
1stvamp ae678fb
docs(run-engine): fix stale references in the CK fairness design docs
1stvamp a5dbe9f
docs(run-engine): add CK virtual-time A/B benchmark plan and harness
1stvamp 33feec3
docs(run-engine): make the e2e bench harness work on self-hosted
1stvamp 23bbfdd
docs(run-engine): add CK virtual-time benchmark results
1stvamp dacfbee
chore(run-engine): gitignore benchmark output artifacts
1stvamp d29c47e
docs(run-engine): benchmark Redis CPU and memory vs concurrency-key c…
1stvamp 8176d48
chore(run-engine): drop benchmark, e2e, and design docs from the branch
1stvamp 1041bb2
fix(run-engine): stop an unservable variant pinning the ck virtual-ti…
1stvamp a755e7c
fix(run-engine): advance the ck virtual-time floor from servable vari…
1stvamp 3a2efa1
fix(run-engine): keep unservable ck variants in the fair order
1stvamp a0f8aed
fix(run-engine): make ck vtime pass 2 discover unregistered variants
1stvamp 1efd05f
test(run-engine): bound the ckManyKeys first-serve claim
1stvamp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| area: webapp | ||
| type: feature | ||
| --- | ||
|
|
||
| The run queue can now serve concurrency keys fairly, so one key with a large backlog no longer starves runs waiting on other keys. It is opt-in and off by default. | ||
|
1stvamp marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.