Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚩 Fix effectiveness depends on library default for autosaveStrategy
The PR removes the explicit
autosaveStrategy={props.autosaveId ? "cookie" : undefined}prop, but callers still passautosaveIdtoResizablePanelGroup(e.g.,apps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.runs.$runParam/route.tsx:511,:587,:780, andapps/webapp/app/routes/_app.orgs.$organizationSlug.projects.$projectParam.env.$envParam.prompts.$promptSlug/route.tsx:589,:596,:1439). Ifreact-window-splitter@0.4.1defaultsautosaveStrategyto"cookie"whenautosaveIdis provided, the removal would be a no-op and cookies would still be written, meaning the HTTP 431 errors would persist. The library's actual default should be verified to confirm this fix is effective.(Refers to lines 7-15)
Was this helpful? React with 👍 or 👎 to provide feedback.