Skip to content

feat(doc-approval): Spec 001/002 event-UI parity across shells #261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
enricopiovesan wants to merge 1 commit into from
Closed

feat(doc-approval): Spec 001/002 event-UI parity across shells #261

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions apps/doc-approval/DocApprovalCore/Sources/DocApprovalCore/PresentationMapper.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ public enum PresentationState: String, Equatable, Sendable {
case error
}

public struct PresentationSnapshot: Equatable, Sendable {
public struct PresentationSnapshot: Equatable, @unchecked Sendable {
public let state: PresentationState
public let errorMessage: String?
public let output: Any?
Expand All @@ -31,7 +31,7 @@ public enum CapabilityPhase: String, Equatable, Sendable {
case result
}

public struct CapabilityProgressStep: Equatable, Sendable {
public struct CapabilityProgressStep: Equatable, @unchecked Sendable {
public let capabilityId: String
public let phase: CapabilityPhase
public let sequence: UInt64
Expand Down Expand Up @@ -61,7 +61,7 @@ public struct CapabilityProgressStep: Equatable, Sendable {
}

/// Minimal embedder event fields required by the mapper.
public struct EmbedderEventLike: Equatable, Sendable {
public struct EmbedderEventLike: Equatable, @unchecked Sendable {
public let eventType: String
public let sequence: UInt64
public let data: [String: Any]
Expand Down
9 changes: 7 additions & 2 deletions apps/doc-approval/DocApprovalCore/Tests/DocApprovalCoreTests/DocApprovalCoreTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,18 @@ final class AppStateViewModelTests: XCTestCase {
XCTAssertNotNil(vm.sessionId)
}

func testResetReturnsToIdle() throws {
func testResetReturnsToIdle() async throws {
let host = try EmbeddedHost.createTestHost(output: sampleOutput)
let vm = AppStateViewModel(host: host, workspaceId: "local-default")
vm.errorMessage = "boom"
vm.document = "document text"
vm.submit()
try await Task.sleep(nanoseconds: 200_000_000)
XCTAssertEqual(vm.currentState, "completed")
vm.reset()
XCTAssertEqual(vm.currentState, "idle")
XCTAssertNil(vm.errorMessage)
XCTAssertNil(vm.output)
XCTAssertEqual(vm.presentationState, .idle)
}
}

Expand Down
Loading