Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
=======================================
Coverage 99.40% 99.40%
=======================================
Files 9 9
Lines 336 336
Branches 38 38
=======================================
Hits 334 334
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
v4.0.0 is tagged but not yet published. Before releasing it, the migration guidance needs to describe the Ruby 3.1 requirement accurately, and CI/tooling should verify the SDK against the current supported Ruby range through Ruby 4.0.
What
After merge, the unpublished v4.0.0 tag will be moved to the merge commit before the gem and GitHub release are published.
Verification
DOCKER_PLATFORM=linux/arm64 TEST_NODE_PARITY=1 RUBY_SDK_E2E=1 ./scripts/test-in-docker.sh(124 runs, 270 assertions, 0 failures, 0 errors, 0 skips)DOCKER_PLATFORM=linux/arm64 RUBY_SDK_E2E=0 ./scripts/test-in-docker.sh bundle exec standardrbDOCKER_PLATFORM=linux/arm64 RUBY_SDK_E2E=0 ./scripts/test-in-docker.sh gem build transloadit.gemspec