fix(expo): avoid logging Android license keys - #2657
Open
Waiel5 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Android Expo config plugin logs the entire props object when modifying AndroidManifest.xml. That object includes the application's license key and can also include legacy add-on keys. Running Expo native configuration therefore copies those values into terminal or CI logs.
Change
Remove the props log. Keep the manifest metadata insertion and the existing key-free add-on migration messages unchanged. Generated plugin files are not tracked in this repository and should be regenerated for the next package release.
Verification
Reproduced with react-native-background-geolocation 5.6.0 in an Expo 57 project using a synthetic license value and
expo config --type introspect: the plugin printed the synthetic Android key before the equivalent compiled-plugin patch, and no longer printed it afterwards. Introspected Android manifest still contained the exact synthetic key undercom.transistorsoft.locationmanager.license; the iOS license entry was unchanged.No real license values are included in this PR. This verifies Expo config-plugin behavior, not a native SDK build or the repository's full test suite.