Add droplet size descriptions and filtering across interactive commands - #84
Open
fcasal wants to merge 2 commits into
Open
Add droplet size descriptions and filtering across interactive commands#84fcasal wants to merge 2 commits into
fcasal wants to merge 2 commits into
Conversation
- Add a Type column from DigitalOcean's own `description` field, so tier names come from the API - Prompts accept a filter: `cpu>=8 mem>=32 price<=300`. - Prompts get readline line editing and up-arrow history.
ret2libc
requested changes
Sep 8, 2026
ret2libc
left a comment
ret2libc
left a comment
Collaborator
There was a problem hiding this comment.
Please use one consistent default unit for memory filters—GB would work—and document it in the prompt help. Currently, mem>=1023 means 1023 GB, while mem>=1024 means 1 GB. Explicit mb/gb/tb suffixes can remain supported.
Filtering should be available wherever users select a droplet size, including interactive creation, initialization, and both resize paths. The shared helper appears to cover these already; please add command-level tests for interactive creation and resizing to verify that integration, and broaden the PR title to reflect the scope.
fcasal
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
descriptionfield, so tier names come from the API and are described vs only a slug name such asso-2vcpu-16gb-intelcpu>=8 mem>=32 price<=300.The following image shows the result of running
? mem >= 16 price <= 200, together with the accompanying machine descriptions