Add missing trailing commas to Python version classifiers in setup.py - #3696
Merged
Merged
Conversation
Without the commas, adjacent string literals concatenate into a single invalid classifier (e.g. 'Programming Language :: Python :: 3.10Programming Language :: Python :: 3.11...'). Fixes the generated lines and the cog template so it doesn't regress on the next cog run.
Member
|
Thanks! I thought we had a linter that checked for this sort of thing but I can't find it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, and thank you for Tornado.
Small
setup.pyfix. The cog-generated Python-version classifiers are missing trailing commas, so the adjacent string literals concatenate into a single invalid classifier:Those five lines evaluate to one string —
"...3.10Programming Language :: Python :: 3.11...3.14"— which isn't a valid PyPI classifier. The last released version on PyPI still shows the correct separate classifiers, so this looks like a recent regression that would ship malformedProgramming Language :: Python :: 3.xmetadata on the next release.This PR adds the trailing commas, and also adds the comma to the
cog.outl(...)template above socog -r setup.pywon't regenerate the bug.For transparency: I used AI assistance to spot and draft this; I verified the source and the current PyPI metadata myself.