Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2025-06-17 - [Optimize Chronological Array Lookups]
**Learning:** In backtesting hot loops (`agent/backtestRunner.ts`) and data source processing (`data/sources/dnsePublic.ts`), time-series data (like OHLCV arrays) is chronologically sorted. Using `Array.prototype.filter` to slice arrays up to a target time results in an unnecessary O(N) full-array scan.
**Action:** Always prefer O(log N) binary search utilities like `findLastBarIndex` when looking up historical time-series data to dramatically improve performance in repeated lookups.
5 changes: 4 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,10 @@
"pnpm": {
"onlyBuiltDependencies": [
"better-sqlite3"
]
],
"overrides": {
"ws": ">=8.21.0"
}
},
"packageManager": "pnpm@10.33.2+sha512.a90faf6feeab71ad6c6e57f94e0fe1a12f5dcc22cd754db40ae9593eb6a3e0b6b12e3540218bb37ae083404b1f2ce6db2a4121e979829b4aff94b99f49da1cf8"
}
11 changes: 7 additions & 4 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 7 additions & 5 deletions src/agent/backtestRunner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { randomUUID } from "node:crypto";
import { loadConfig } from "../config/loader.js";
import { getDb } from "../storage/db.js";
import { getBacktestBroker } from "../broker/index.js";
import { getStockOhlcv, getIndexOhlcv, type Bar } from "../data/sources/dnsePublic.js";
import { getStockOhlcv, getIndexOhlcv, type Bar, findLastBarIndex } from "../data/sources/dnsePublic.js";
import { DISCOVERY_UNIVERSE, discoverTickers } from "../tools/discover.js";
import { setActiveAsOf } from "./clock.js";
import { runTeamAnalysis } from "./team/index.js";
Expand Down Expand Up @@ -298,8 +298,8 @@ export async function runBacktestSession(
);

const vnindexAt = (asOf: number): number | null => {
const series = vnindex.filter((b) => b.time <= asOf);
return series.length ? series[series.length - 1]!.close : null;
const idx = findLastBarIndex(vnindex, asOf);
return idx === -1 ? null : vnindex[idx]!.close;
};
const vnindexBaseline = vnindexAt(intervalTurns[0]!);
if (vnindexBaseline == null) throw new Error(`no VNINDEX data at first ${interval.label} turn`);
Expand All @@ -312,8 +312,10 @@ export async function runBacktestSession(
throwIfAborted(cb.signal);
const dateIso = ictLabel(asOf);
const priceOverride = (sym: string): number | null => {
const series = bars[sym]?.filter((b) => b.time <= asOf) ?? [];
return series.length ? series[series.length - 1]!.close : null;
const series = bars[sym];
if (!series || series.length === 0) return null;
const idx = findLastBarIndex(series, asOf);
return idx === -1 ? null : series[idx]!.close;
};
broker.setPriceOverride(priceOverride);
cb.onTurnStart?.({ asOf, dateIso });
Expand Down
28 changes: 27 additions & 1 deletion src/data/sources/dnsePublic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -61,14 +61,40 @@ export function seriesToBars(s: OhlcvSeries): Bar[] {
return out;
}

/**
* ⚡ Bolt: O(log N) binary search for chronological time-series lookups.
*
* Replaces O(N) Array.prototype.filter() allocations. Since Ohlcv time-series
* arrays are strictly chronologically sorted, we can locate the target time bound
* in milliseconds rather than iterating through the entire historical dataset.
*/
export function findLastBarIndex(bars: Bar[], targetTime: number): number {
let low = 0;
let high = bars.length - 1;
let result = -1;

while (low <= high) {
const mid = Math.floor((low + high) / 2);
if (bars[mid]!.time <= targetTime) {
result = mid;
low = mid + 1;
} else {
high = mid - 1;
}
}

return result;
}

function clipBars(bars: Bar[]): Bar[] {
// Clip when an as-of clock is active (ALS or module override). When neither
// is set, fall through unchanged — DNSE only returns historical data anyway.
const hasOverride =
asOfClock.getStore()?.asOfSec != null || isAsOfOverridden();
if (!hasOverride) return bars;
const asOf = nowSec();
return bars.filter((b) => b.time <= asOf);
const idx = findLastBarIndex(bars, asOf);
return idx === -1 ? [] : bars.slice(0, idx + 1);
}

export async function getStockOhlcv(
Expand Down
Loading