Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2026-06-15 - Optimize Array Lookups with Binary Search
**Learning:** Backtests in this codebase loop over thousands of intervals across dozens of tickers. Using O(n) `Array.prototype.filter()` for chronologically sorted time-series lookups (like finding the latest price before `asOf`) is a major performance bottleneck due to CPU cycles and garbage collection from new array allocations.
**Action:** Replace `array.filter(b => b.time <= asOf)` with an O(log n) binary search utility `findLastBarIndex` when searching sorted chronological series like OHLCV data.
12 changes: 7 additions & 5 deletions src/agent/backtestRunner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { randomUUID } from "node:crypto";
import { loadConfig } from "../config/loader.js";
import { getDb } from "../storage/db.js";
import { getBacktestBroker } from "../broker/index.js";
import { getStockOhlcv, getIndexOhlcv, type Bar } from "../data/sources/dnsePublic.js";
import { getStockOhlcv, getIndexOhlcv, findLastBarIndex, type Bar } from "../data/sources/dnsePublic.js";
import { DISCOVERY_UNIVERSE, discoverTickers } from "../tools/discover.js";
import { setActiveAsOf } from "./clock.js";
import { runTeamAnalysis } from "./team/index.js";
Expand Down Expand Up @@ -298,8 +298,8 @@ export async function runBacktestSession(
);

const vnindexAt = (asOf: number): number | null => {
const series = vnindex.filter((b) => b.time <= asOf);
return series.length ? series[series.length - 1]!.close : null;
const idx = findLastBarIndex(vnindex, asOf);
return idx !== -1 ? vnindex[idx]!.close : null;
};
const vnindexBaseline = vnindexAt(intervalTurns[0]!);
if (vnindexBaseline == null) throw new Error(`no VNINDEX data at first ${interval.label} turn`);
Expand All @@ -312,8 +312,10 @@ export async function runBacktestSession(
throwIfAborted(cb.signal);
const dateIso = ictLabel(asOf);
const priceOverride = (sym: string): number | null => {
const series = bars[sym]?.filter((b) => b.time <= asOf) ?? [];
return series.length ? series[series.length - 1]!.close : null;
const symBars = bars[sym];
if (!symBars || symBars.length === 0) return null;
const idx = findLastBarIndex(symBars, asOf);
return idx !== -1 ? symBars[idx]!.close : null;
};
broker.setPriceOverride(priceOverride);
cb.onTurnStart?.({ asOf, dateIso });
Expand Down
30 changes: 29 additions & 1 deletion src/data/sources/dnsePublic.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,31 @@ export interface Bar {
volume: number;
}

/**
* Finds the index of the latest bar whose time is <= timeSec.
* Returns -1 if no such bar exists.
* Assumes `bars` is sorted chronologically by time.
*/
export function findLastBarIndex(bars: Bar[], timeSec: number): number {
let left = 0;
let right = bars.length - 1;
let ans = -1;

while (left <= right) {
const mid = Math.floor((left + right) / 2);
const midTime = bars[mid]!.time;

if (midTime <= timeSec) {
ans = mid;
left = mid + 1; // Try to find a later bar that is still <= timeSec
} else {
right = mid - 1;
}
}

return ans;
}

async function fetchOhlcs(
kind: "stock" | "index",
symbol: string,
Expand Down Expand Up @@ -68,7 +93,10 @@ function clipBars(bars: Bar[]): Bar[] {
asOfClock.getStore()?.asOfSec != null || isAsOfOverridden();
if (!hasOverride) return bars;
const asOf = nowSec();
return bars.filter((b) => b.time <= asOf);

const idx = findLastBarIndex(bars, asOf);
if (idx === -1) return [];
return bars.slice(0, idx + 1);
}

export async function getStockOhlcv(
Expand Down
Loading