Skip to content

Push LCD labels on bindings save, not only on activation #5

Description

@tophcodes

Currently _push_labels only runs on workbench activation (lifecycle.py:69). Saving new bindings via the dialog updates App.ParamGet but doesn't refresh the LCD until the next activation.

We should call _push_labels from BindingsDialog._save (button_dialog.py:50), or document that labels only refresh on activation.

See #2.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions