Skip to content

Add exact deterministic DeepEP training - #86

Open
kiddyboots216 wants to merge 1 commit into
mainfrom
review/deepep-exact-pr-20260823
Open

Add exact deterministic DeepEP training#86
kiddyboots216 wants to merge 1 commit into
mainfrom
review/deepep-exact-pr-20260823

Conversation

@kiddyboots216

Copy link
Copy Markdown
Contributor

Summary

Add the XoRL trainer half of the native deterministic DeepEP zero-K3 contract.

Dependencies:

Changes

  • add native-exact DeepEP dispatch/combine with one-call deterministic reduction
  • support exact Qwen3, Qwen3.5, GLM-5.2, and DeepSeek-V4 model paths
  • preserve BF16 communicated expert leaves with the canonical higher-precision fold
  • integrate active LoRA, router training/publication, shared-expert joins, packed rows, and context/pipeline parallel layouts
  • pin the matching DeepEP and SGLang Kernel release artifacts and the serving submodule commit
  • reject unsupported checkpoint, EP-size, and topology combinations before execution

Validation

  • focused exact-path trainer tests
  • packed-boundary, empty-rank autograd, CP, PP, LoRA, and router-sidecar regressions
  • deterministic DeepEP release-lock and ABI checks
  • forward/backward and optimizer-update component coverage
  • source formatting and static checks

@broly-code-security-scanner

broly-code-security-scanner Bot commented Aug 23, 2026

Copy link
Copy Markdown

Broly Security Scan

Note

Clean scan
No vulnerabilities detected in this PR.

Note

Re-scan this PR anytime with /broly scan — useful after /broly undismiss, or to refresh findings without a new push.

Broly — SAST (zai-org/GLM-5.2) · Secrets · SCA · IaC · GH Actions · Base Images · Supply Chain Threats · Exploit Chains · Adversarial Verification

We're continuously improving Broly's accuracy and finding quality — your feedback is valuable. False positives, missed findings, bugs, and feature requests all welcome.

Ask in #security-engineering   Powered by Together AI

Comment thread src/xorl/distributed/moe/deepep_native_exact.py Fixed
Comment thread tests/distributed/test_deepep_rank_leaf_real.py Fixed
Comment thread src/xorl/distributed/moe/deepep_native_exact.py Fixed
@kiddyboots216
kiddyboots216 force-pushed the review/deepep-exact-pr-20260823 branch 4 times, most recently from 467e7a8 to 54e045d Compare August 24, 2026 02:22
@kiddyboots216
kiddyboots216 force-pushed the review/deepep-exact-pr-20260823 branch from 54e045d to f8b05e1 Compare August 24, 2026 02:28
@kiddyboots216
kiddyboots216 requested a review from qywu August 25, 2026 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants