Skip to content

fix: support macOS 13 and add English/Korean localization - #4

Open
122yjs wants to merge 2 commits into
toddwyl:mainfrom
122yjs:feat/english-korean-localization
Open

fix: support macOS 13 and add English/Korean localization#4
122yjs wants to merge 2 commits into
toddwyl:mainfrom
122yjs:feat/english-korean-localization

Conversation

@122yjs

@122yjs 122yjs commented Jul 30, 2026

Copy link
Copy Markdown

Summary

This PR contains the completed local compatibility and localization work:

  • Fix the release build so the Mach-O deployment target matches LSMinimumSystemVersion=13.0.
  • Make English the development and fallback language.
  • Add Korean localization for the SwiftUI window, menu-bar menu, alerts, notifications, help, and permission text.
  • Copy localization resources without inherited quarantine/provenance attributes.
  • Add regression checks for localization key parity, format placeholders, resource inclusion, code signing, and Mach-O minos.
  • Remove the Sequoia-failing iconutil build step and use the standard macOS app icon.

Language behavior

  • English is the default and fallback.
  • Korean is selected when Korean is preferred in macOS.
  • Unsupported languages fall back to English.

Verification

Tested on macOS 15.7.7 Sequoia (24G720), Apple Silicon, Swift 6.1.2, and macOS SDK 15.5.

./check.sh
Localization checks passed: English default, Korean available
Checks passed: macOS deployment target 13.0

Additional verification:

  • English lookup: Never Sleep, Settings
  • Korean lookup: 잠자기 방지, 설정
  • Unsupported language lookup falls back to English
  • Swift compilation and type checking pass
  • .strings and plist validation pass
  • English/Korean localization key sets match
  • %@ and %d format placeholders match
  • App code-signature verification passes
  • Built executable reports minos 13.0

Closes #2

Note: The same commit is also present in the earlier Draft PR #3. This PR is opened from the dedicated feat/english-korean-localization branch so the localization work has its own reviewable branch.

JSM2 added 2 commits July 28, 2026 23:36
Build for the minimum macOS version declared in Info.plist, ad-hoc sign the local app bundle, and add a regression check that compares the plist value with the Mach-O minos field.
Use English as the development and fallback language, add Korean resources for the window, menu, alerts, notifications, help, and permission text, and validate localization key and format-string parity during builds.
@122yjs 122yjs changed the title feat: add English and Korean localization fix: support macOS 13 and add English/Korean localization Jul 30, 2026
@122yjs
122yjs marked this pull request as ready for review July 30, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

v2.2.0 binary targets macOS 26 despite declaring macOS 13

1 participant