TINYINT-3455: Update details - #79
Open
tiny-ben-tran wants to merge 3 commits into
Open
tiny-ben-tran wants to merge 3 commits into
tiny-ben-tran wants to merge 3 commits into
Conversation
tiny-ben-tran
marked this pull request as ready for review
September 25, 2026 02:38
tiny-ben-tran
requested review from
a team,
MitchC1999,
TheSpyder,
hamza0867,
shanmen-tiny,
soritaheng and
spocke
and removed request for
a team
September 25, 2026 02:38
metricjs
approved these changes
Sep 25, 2026
|
|
||
| External contributors are free to submit PRs against the `main` branch. | ||
| Note that contributions will require signing of our Contributor License Agreement. | ||
| In order for Tiny to accept your contribution, we will need legal permission from you to use your code. Please email `legal@tiny.cloud` with the subject `CLA request for [your Github username]`. Our legal team will send you a Contributors License Agreement (CLA) which you will need to sign and return. |
There was a problem hiding this comment.
this is missing a line compared to the usual template, right? 'welcome to make prs' or someting
| ## About | ||
|
|
||
| Web Components are a set of built-in browser capabilities that let developers create custom HTML elements in a similar manner to what is available in frameworks like React or Angular. | ||
| Official Web Component for TinyMCE, the rich text editor. It wraps TinyMCE as a `<tinymce-editor>` custom element, used in place of calling `tinymce.init()`. By default, it pulls TinyMCE from the Tiny Cloud CDN unless configured to use a different setup, such as self-hosting the [tinymce NPM package](https://www.npmjs.com/package/tinymce). |
There was a problem hiding this comment.
I am wondering if we should add another sentence or two from the old content that explains what exactly this is/how to use it? I don't know web components well, or how much most devs would know about them / what they might be looking for that would lead them to this integration though tbh.
|
|
||
| ### Self hosted via NPM package | ||
|
|
||
| Using TinyMCE from NPM with the Web Component requires a couple of extra steps. See the documentation for more information: [Using TinyMCE with Web Components - Self hosted via NPM](https://www.tiny.cloud/docs/tinymce/latest/webcomponent-pm/) |
There was a problem hiding this comment.
Suggested change
| Using TinyMCE from NPM with the Web Component requires a couple of extra steps. See the documentation for more information: [Using TinyMCE with Web Components - Self hosted via NPM](https://www.tiny.cloud/docs/tinymce/latest/webcomponent-pm/) | |
| Using TinyMCE from NPM with the Web Component integration requires a couple of extra steps. See the documentation for more information: [Using TinyMCE with Web Components - Self hosted via NPM](https://www.tiny.cloud/docs/tinymce/latest/webcomponent-pm/) |
i think this needs another word. up further too...
| @@ -1,19 +1,51 @@ | |||
| # Official Web Component for TinyMCE | |||
There was a problem hiding this comment.
Suggested change
| # Official Web Component for TinyMCE | |
| # Official Web Component integration for TinyMCE |
needs another word, otherwise it sounds like we're using 'component' the way we do for the react integration, etc.
There was a problem hiding this comment.
commented on a couple like this but i may have missed instances - please check
| ## About | ||
|
|
||
| Web Components are a set of built-in browser capabilities that let developers create custom HTML elements in a similar manner to what is available in frameworks like React or Angular. | ||
| Official Web Component for TinyMCE, the rich text editor. It wraps TinyMCE as a `<tinymce-editor>` custom element, used in place of calling `tinymce.init()`. By default, it pulls TinyMCE from the Tiny Cloud CDN unless configured to use a different setup, such as self-hosting the [tinymce NPM package](https://www.npmjs.com/package/tinymce). |
There was a problem hiding this comment.
Suggested change
| Official Web Component for TinyMCE, the rich text editor. It wraps TinyMCE as a `<tinymce-editor>` custom element, used in place of calling `tinymce.init()`. By default, it pulls TinyMCE from the Tiny Cloud CDN unless configured to use a different setup, such as self-hosting the [tinymce NPM package](https://www.npmjs.com/package/tinymce). | |
| Official Web Components integration for TinyMCE, the rich text editor. It wraps TinyMCE as a `<tinymce-editor>` custom element, used in place of calling `tinymce.init()`. By default, it pulls TinyMCE from the Tiny Cloud CDN unless configured to use a different setup, such as self-hosting the [tinymce NPM package](https://www.npmjs.com/package/tinymce). |
also wondering if there should be an s on Component now...
| @@ -1,2 +1,2 @@ | |||
| { | |||
| "description": "Official TinyMCE Web Component", | |||
There was a problem hiding this comment.
Suggested change
| "description": "Official Web Component integration for TinyMCE rich text editor", |
to match the others?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related tickets: TINYINT-3455
Description of changes: