Skip to content

test: wait for TinyDocs module to finish serving - #26

Merged
senamakel merged 1 commit into
mainfrom
fix/module-e2e-await-idle
Oct 4, 2026
Merged

senamakel merged 1 commit into
mainfrom
fix/module-e2e-await-idle

Conversation

@senamakel

Copy link
Copy Markdown
Member

The real-module E2E sometimes observed TinyBus`s transient Serving state immediately after the final reply: the caller can receive the reply before the host retires the in-flight count. Wait briefly for the module to settle back to Ready, while failing immediately on any terminal or unexpected state.\n\nValidation: cargo fmt --all -- --check; the ignored module E2E against the published v0.1.21 Ubuntu 24.04 artifact.

Co-authored-by: Medulla <medulla@tinyhumans.ai>
@tinysweeper

tinysweeper Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Tiny Sweeper review

Tiny Sweeper reviewed this change across 6 lane(s) and found 0 active actionable finding(s). Detailed lane evidence and any incomplete work are listed below.

State: Incomplete
Priority: none
Reviewed head: 3e2146b5a125
Updated: 1791104047 (Unix time)

Review snapshot

Change surface Files Review signal Count
Production 0 Active findings 0
Tests 1 Noted findings 0
Documentation 0 Resolved findings 0
Configuration 0 Pending checks/questions 2

Completeness: Incomplete
Test assessment: No supported feature-to-test mapping was available; this does not mean tests are absent or passed.

What changed

The review could not produce a supported behavioral summary; inspect the cited changed surface and lane details below.

Features

None identified with supported citations.

Tests

No supported feature-to-test mapping was produced. Test execution is not inferred.

Findings

No active actionable findings.

Could not review: crates/tinydocs-module/tests/module_e2e.rs

Before merge

  • Complete the critique review for crates/tinydocs-module/tests/module_e2e.rs.
  • Complete the security review for crates/tinydocs-module/tests/module_e2e.rs.

How this fits together

flowchart LR
  n0["...le_serves_every_format_over_a_real_broker<br/>changed"]:::changed
  n1["wait_until_serving<br/>changed"]:::changed
  n2["as_str"]:::impacted
  n3["extracts_text_from_a_streamed_pdf"]:::impacted
  n4["generates_a_pptx_from_a_streamed_image_pair"]:::impacted
  n5["new"]:::impacted
  n6["refuses_a_stream_that_contradicts_the_spec"]:::impacted
  n7["OutputRef"]:::impacted
  n0 -->|calls| n1
  n0 -->|calls| n3
  n0 -->|calls| n4
  n0 -->|calls| n5
  n0 -->|calls| n6
  n1 -->|calls| n2
  n1 -->|tests| n2
  n3 -->|calls| n5
  n3 -->|uses| n7
  n4 -->|calls| n5
  n4 -->|uses| n7
  n6 -->|calls| n5
  n6 -->|uses| n7
  classDef changed fill:#0d4429,stroke:#238636,color:#e6edf3
  classDef impacted fill:#161b22,stroke:#6e7681,color:#c9d1d9
  classDef flagged fill:#5a1e02,stroke:#d93f0b,color:#ffffff
  classDef blocking fill:#67060c,stroke:#f85149,color:#ffffff
Loading
Agent review details

critique

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: crates/tinydocs-module/tests/module_e2e.rs
  • Lane summary: Reviewed 0 files; 0 findings. 1 file could not be reviewed: crates/tinydocs-module/tests/module_e2e.rs.

security

  • Conclusion: Neutral
  • Scope reviewed: incomplete; unanswered: crates/tinydocs-module/tests/module_e2e.rs
  • Lane summary: Reviewed 0 files; 0 findings. 1 file could not be reviewed: crates/tinydocs-module/tests/module_e2e.rs.

tests

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.

commits

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: Nothing sensitive found in what this pull request commits.

description

  • Conclusion: Success
  • Scope reviewed: all assigned evidence
  • Lane summary: Replaces a direct assertion on module state with a polling loop that tolerates a transient Serving state, preventing flaky failures in the E2E test. The change is sound and follows the project's coding conventions for test code. _Code retrieval was unavailable (model: ladder embeddings returned 502 Bad Gateway: {"error":{"message":"no rung of ladder vectors could serve the request","skipped":[{"model":"text-embedding-bge-m3","provider":"venice","reason":"rate limited, retry in 14s","rung":0}],"type":"ladder_router_error"}}), so this review saw the diff alone._ _Memory was unavailable (model: cortex: v1/recall: timed out after 10s), so this review ran without it._

e2e

  • Conclusion: Neutral
  • Scope reviewed: all assigned evidence
  • Lane summary: No behavioural change: nothing outside documentation, configuration and tests.
Evidence and run details
  • Models: deepseek/deepseek-v4-flash
  • Spend: $0.001181
  • Tokens: 5333 input · 3892 output · 0 cached · 0 embedding
Head State Pass summary
3e2146b5a125 incomplete 0 active finding(s), 0 resolved finding(s) (at 1791104047)

tinysweeper 0.1.0

@coderabbitai

coderabbitai Bot commented Oct 4, 2026

Copy link
Copy Markdown

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

Or wait 25 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dee0f999-e14a-4fc9-b4fb-e084018667b2
📥 Commits

Reviewing files that changed from the base of the PR and between 7bec416 and 3e2146b.

📒 Files selected for processing (1)
  • crates/tinydocs-module/tests/module_e2e.rs
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-04T08:55:29.682065Z 3e2146b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tinysweeper tinysweeper Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tinysweeper found nothing blocking, but could not review everything, so this is not an approval: crates/tinydocs-module/tests/module_e2e.rs.

             $0.0012 · 5,333 in / 3,892 out · 0 cached (0%) · deepseek/deepseek-v4-flash
description: $0.0005 · 3,578 in / 803 out   · 0 cached (0%) · deepseek/deepseek-v4-flash

@tinysweeper tinysweeper Bot added the priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect. label Oct 4, 2026
@senamakel
senamakel merged commit a051785 into main Oct 4, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

priority: p3 Whenever. Cosmetic, a nicety, or a cleanup with no user visible effect.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant