Use constant-time comparison for output prefix verification in MAC#73
Open
JACKURUVI99 wants to merge 1 commit into
Open
Use constant-time comparison for output prefix verification in MAC#73JACKURUVI99 wants to merge 1 commit into
JACKURUVI99 wants to merge 1 commit into
Conversation
Arrays.equals() and util.Bytes.equals() exit on the first mismatching byte, leaking timing information in security-sensitive MAC verification paths. Replace with MessageDigest.isEqual() (constant-time) in: - ChunkedHmacImpl.createVerification() — output prefix check - ChunkedAesCmacImpl.createVerification() — output prefix check - LegacyFullMac.verifyMac() — prefix check before rawMac.verifyMac() Consistent with the fix already applied in ChunkedMacVerificationFromComputation (175df91). Fixes tink-crypto#72.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three places in MAC verification use non-constant-time comparisons for the output prefix check, inconsistent with the fix recently applied in
ChunkedMacVerificationFromComputation(175df91).ChunkedHmacImpl.createVerification()—util.Bytes.equals()→Arrays.equals()(non-CT)ChunkedAesCmacImpl.createVerification()— sameLegacyFullMac.verifyMac()—Arrays.equals()directly (non-CT)All three are replaced with
MessageDigest.isEqual()which is guaranteed constant-time by the JCA spec, consistent with the pattern already used inChunkedMacVerificationFromComputation.Files Changed
ChunkedHmacImpl.javaBytes.equals()→MessageDigest.isEqual()ChunkedAesCmacImpl.javaBytes.equals()→MessageDigest.isEqual()LegacyFullMac.javaArrays.equals()→MessageDigest.isEqual()Fixes #72.