Skip to content

fix - bulk optimization compression results past 9 are not shown - #123

Open
tijmenbruggeman wants to merge 4 commits into
tinify:masterfrom
wcreateweb:bulk-row-stock-waiting
Open

fix - bulk optimization compression results past 9 are not shown#123
tijmenbruggeman wants to merge 4 commits into
tinify:masterfrom
wcreateweb:bulk-row-stock-waiting

Conversation

@tijmenbruggeman

@tijmenbruggeman tijmenbruggeman commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

drawSomeRows() records the last index it drew instead of how many rows it has drawn. Therefor compression more than 10 images would never show the results of images past 9.

Tricky to add a regression test as it requires more than 10 images to validate.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected row-count tracking so the total number of rendered rows is reported accurately.
    • Improved incremental rendering to prevent previously rendered rows from being redrawn.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: d66ca377-c5f2-4e29-a6f4-ac3519f4284f

📥 Commits

Reviewing files that changed from the base of the PR and between 6527740 and cfb40d6.

📒 Files selected for processing (1)
  • src/js/bulk-optimization.js
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/js/bulk-optimization.js

Included review availability: 3 reviews are currently available. Based on recent review activity, included reviews refill at 5 per hour.


📝 Walkthrough

Walkthrough

drawSomeRows now calculates explicit row bounds, renders that range, and stores the range end in window.totalRowsDrawn for subsequent rendering passes.

Changes

Bulk optimization

Layer / File(s) Summary
Advance rendered row range
src/js/bulk-optimization.js
drawSomeRows now derives bounded start and end indices, iterates through the range, and stores the end index in window.totalRowsDrawn.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to cfb40

This change corrects bulk compression result display for images beyond the first 10. No actionable merge-blocking risk remains after normal checks and review.

Poem

I bound the rows from start to end,
Each little row becomes a friend.
The cursor marks the final flight,
So later passes begin just right.
Squeak! The render hops along.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the fix for bulk optimization results not appearing beyond image 9.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant