Repository navigation
Conversation
…507) skills add: a skill whose frontmatter carries reference-only: true (or "true") generates no command file and is counted in a visible skip line; unmarked siblings in the same install still generate. skills update: a stale generated command for a reference-only skill is deleted (the pre-marker install artifact); a user-authored file with the same name is left untouched. Implements the adlc-cli half of adlc-workspace ADR-507 (factory-runbook is reference-only - never invoked, no slash command). Both guarded call sites are pinned by tests/reference-only.test.mjs (passes with the change, fails without it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the adlc-cli half of adlc-workspace ADR-507 (
factory-runbookis reference-only — never invoked, no slash command).What
reference-only: truefrontmatter marker, honored at both call sites ADR-507 names:skills add— marked skills generate no command file; a visibleSkipped N reference-only skill(s) (no command file)line reports the count; unmarked siblings still generate.skills update— a stale generated command for a marked skill is deleted (the pre-marker install artifact); a user-authored file with the same name is left untouched (counts asuser-modified (skipped)).No skill carries the marker yet — this lands the guard ahead of the
adlc-team-skillsside (flag onfactory-runbook+ Python test assertions), which follows in a separate PR.Tests
tests/reference-only.test.mjsrunscmdAdd/cmdUpdatefor real through the CLI binary against temp-dir fixtures, with thenpx skillsinstaller PATH-stubbed (same hermetic pattern asteam-mcp-chain.test.mjs) and--no-eventskeeping the events fetch offline. Both marker spellings (truebare,"true"quoted) are pinned.Verified: passes with the change, fails without it (checked by reverting the
skills.mjsdiff).Verification
npm test— 950/950 pass + both e2e suites greennpm run format:check— cleanrmSyncguarded byexistsSync+isGeneratedon the same path computation the existingwriteFileSyncpath already uses