Skip to content

feat(skills): skip command generation for reference-only skills (ADR-507) - #89

Open
kanfil wants to merge 1 commit into
mainfrom
feat/reference-only-command-skip
Open

kanfil wants to merge 1 commit into
mainfrom
feat/reference-only-command-skip

Conversation

@kanfil

@kanfil kanfil commented Nov 13, 2026

Copy link
Copy Markdown
Member

Implements the adlc-cli half of adlc-workspace ADR-507 (factory-runbook is reference-only — never invoked, no slash command).

What

reference-only: true frontmatter marker, honored at both call sites ADR-507 names:

  • skills add — marked skills generate no command file; a visible Skipped N reference-only skill(s) (no command file) line reports the count; unmarked siblings still generate.
  • skills update — a stale generated command for a marked skill is deleted (the pre-marker install artifact); a user-authored file with the same name is left untouched (counts as user-modified (skipped)).

No skill carries the marker yet — this lands the guard ahead of the adlc-team-skills side (flag on factory-runbook + Python test assertions), which follows in a separate PR.

Tests

tests/reference-only.test.mjs runs cmdAdd/cmdUpdate for real through the CLI binary against temp-dir fixtures, with the npx skills installer PATH-stubbed (same hermetic pattern as team-mcp-chain.test.mjs) and --no-events keeping the events fetch offline. Both marker spellings (true bare, "true" quoted) are pinned.

Verified: passes with the change, fails without it (checked by reverting the skills.mjs diff).

Verification

  • npm test — 950/950 pass + both e2e suites green
  • npm run format:check — clean
  • Pre-commit security checklist (CDR-2026-020): no secrets, no new deps, rmSync guarded by existsSync + isGenerated on the same path computation the existing writeFileSync path already uses

…507)

skills add: a skill whose frontmatter carries reference-only: true (or
"true") generates no command file and is counted in a visible skip
line; unmarked siblings in the same install still generate.

skills update: a stale generated command for a reference-only skill is
deleted (the pre-marker install artifact); a user-authored file with
the same name is left untouched.

Implements the adlc-cli half of adlc-workspace ADR-507 (factory-runbook
is reference-only - never invoked, no slash command). Both guarded call
sites are pinned by tests/reference-only.test.mjs (passes with the
change, fails without it).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant