Skip to content

feat(iam): implement deleteTeam method - #257

Merged
designcode merged 1 commit into
mainfrom
feat/iam/delete-team
Aug 19, 2026
Merged

feat(iam): implement deleteTeam method#257
designcode merged 1 commit into
mainfrom
feat/iam/delete-team

Conversation

@designcode

@designcode designcode commented Aug 19, 2026

Copy link
Copy Markdown
Collaborator

Note

Medium Risk
Destructive IAM team deletion is a sensitive operation; the change is small and follows existing team API patterns but callers can permanently remove teams if misused.

Overview
Adds deleteTeam to @tigrisdata/iam, completing team lifecycle support alongside existing create/edit/list helpers.

The new API issues a DELETE to teams/{teamId}, mirrors other team methods for client setup and status: 'error' handling, and returns { data: { teamId } } on success. Types and the function are re-exported from the package entrypoint. A minor changeset documents the release; Biome’s JSON schema URL is bumped to 2.5.8.

Reviewed by Cursor Bugbot for commit af43f96. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 8797091. Configure here.

Comment thread packages/iam/src/lib/team/delete.ts
@greptile-apps

greptile-apps Bot commented Aug 19, 2026

Copy link
Copy Markdown

Greptile Summary

Adds the public deleteTeam IAM API and its release changeset, while updating the Biome schema reference.

  • Exports new delete-team option and response types from the IAM package entrypoint.
  • Sends a DELETE request for a supplied team ID and returns that ID on success.
  • Adds a minor-version changeset for @tigrisdata/iam.

Confidence Score: 3/5

The PR is not safe to merge until deleteTeam uses the management endpoint and propagates application-level deletion errors.

The new operation currently targets the default IAM backend rather than the team management backend, and it can return success for response bodies that explicitly report an error.

Files Needing Attention: packages/iam/src/lib/team/delete.ts

Important Files Changed

Filename Overview
packages/iam/src/lib/team/delete.ts Implements team deletion, but routes it through the wrong backend and fails to handle application-level error responses.
packages/iam/src/index.ts Correctly exposes the new deleteTeam function and its public types.
.changeset/feat-iam-delete-teams.md Adds an appropriate minor changeset for the new public IAM method.
biome.json Updates only the Biome schema URL from 2.5.6 to 2.5.8.

Reviews (1): Last reviewed commit: "feat(iam): implement deleteTeam method" | Re-trigger Greptile

Comment thread packages/iam/src/lib/team/delete.ts
Comment thread packages/iam/src/lib/team/delete.ts
@designcode
designcode force-pushed the feat/iam/delete-team branch from 8797091 to af43f96 Compare August 19, 2026 12:09
@designcode
designcode merged commit 6b090d4 into main Aug 19, 2026
2 checks passed
@designcode
designcode deleted the feat/iam/delete-team branch August 19, 2026 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants