Fix browser quickstart profile management - #82
Open
janithjay wants to merge 1 commit into
Open
Conversation
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
janithjay
force-pushed
the
fix-browser-quickstart-profile-management
branch
from
August 17, 2026 11:20
a2086b5 to
4d3cdbc
Compare
janithjay
marked this pull request as ready for review
August 17, 2026 11:23
Signed-off-by: janithjay <janithjayashan018@gmail.com>
janithjay
force-pushed
the
fix-browser-quickstart-profile-management
branch
from
August 17, 2026 11:38
4d3cdbc to
04bdb64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The "Manage Profile" dialog in
samples/browser/quickstartwas broken. Saving any field failed with a400 Schema validation failedfromPUT /users/me, and the dialog only rendered two hardcoded fields (First name, Last name) populated from ID token claims instead of the user's real profile attributes, with no schema validation.Approach
@thunderid/browseris a headless, framework-agnostic layer. It ships no UI components. So the quickstart's hand-rolled dialog had drifted out of sync with what components actually do, and was sending a hardcoded, wrongly-shaped payload ({ name: { givenName, familyName } }) instead of the deployment's real (flat) schema attribute names.Rewrote
profileDialog.jsto mirror@thunderid/react/@thunderid/vue'sBaseUserProfilebehavior instead of hardcoding shapes,getUsersMeMeta) and current attributes (getUsersMe) before rendering.BaseUserProfile.required/regexagainst the schema client-side before submitting.deepMergebeforePUT /users/me, since that endpoint replaces the whole attributes document rather than merging.picture.After fixes
Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks