Repository navigation
Conversation
|
Some actions not available on multiselecting: |
Add missing newline at the end of SelectionMode.kt
Fix missing newline at the end of profile_selection_menu.xml
Contributor
Author
Done, added Resolve domains and Clear traffic statistics to the multiselect menu. Updated the PR. |
Thank you. Sharing needs enhancements for consistency: Names are not the same: copy link vs export to clipboard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I looked into #140, which requested an action for multi-selecting profiles. Options like testing, deleting, QR, clearing, and "select all" were already present; all that was missing was an "invert selection" feature. I’ve added it.
Changes made:
invertSelection()function. It iterates through the visible profiles in the list and toggles each checkbox. If no items remain selected after this operation, the selection mode closes—just as it would when the last checkbox is unchecked. I also hooked up the new menu item inonMenuItemClick.action_selection_invertitem to the selection menu, positioned right after "Select all."Profiles_invert_selection("Invert selection").I haven’t touched the other languages; they will default to English.
Closes #140