Migrate to zos_base@v1.1.0 + zos_sdk_go@v0.18.0#20
Merged
Conversation
grid-cli, grid-agent-gui: repoint zosbase -> zos_base@v1.1.0 and tfgrid-sdk-go/*
-> zos_sdk_go/{grid-client,grid-proxy,rmb-sdk-go}@v0.18.0. Imports gofmt'd,
go.mod/go.sum updated. grid-cli builds; grid-agent-gui Go compiles (frontend/dist
embed built by CI). Graph has no zosbase or tfgrid-sdk-go.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The module bump to `go 1.25.0` (grid-cli, grid-agent-gui) was not propagated
to the workspace or CI, breaking every workspace-mode build:
go: module grid-cli listed in go.work file requires go >= 1.25.0,
but go.work lists go 1.24
- go.work: go 1.24 -> 1.25.0, toolchain go1.24.2 -> go1.25.0 so the workspace
(and `go work sync` via `make tidy`/`work-sync`) resolves again.
- release.yml: pin setup-go 1.23 -> 1.25 so release builds don't rely on
implicit toolchain auto-download for the 1.25.0 modules.
- grid-cli/Makefile: repoint the `-X` ldflags from the stale monorepo path
github.com/threefoldtech/tfgrid-sdk-go/grid-cli/cmd to the real module
github.com/threefoldtech/grid-agent/grid-cli/cmd, so version/commit
injection stops silently no-op'ing (verified: `tfcmd version` now reports
the tag + commit).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QBTXyiV6w44ZBtDAikJ6uZ
Complete the rename cleanup the migration missed (non-build docs): - repo URLs (releases/issues/clone) tfgrid-sdk-go -> grid_agent - agent/README import + go get paths -> the real module path github.com/threefoldtech/grid-agent/agent - agent/README "Related Projects" SDK link -> renamed zos_sdk_go - grid-agent-gui desktop entry example path -> grid_agent Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QBTXyiV6w44ZBtDAikJ6uZ
sameh-farouk
approved these changes
Jul 14, 2026
sameh-farouk
left a comment
sameh-farouk
left a comment
Member
There was a problem hiding this comment.
Approving after verifying the migration and adding fixes for the workspace/CI Go 1.25.0 propagation, grid-cli Makefile ldflags path, and stale tfgrid-sdk-go doc references. Local build/vet/tests green across all three modules; workspace (go.work) resolves and tfcmd version now injects tag+commit correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete migration off the rename redirects (grid-cli + grid-agent-gui): zosbase -> zos_base@v1.1.0 and tfgrid-sdk-go/* -> zos_sdk_go/{grid-client,grid-proxy,rmb-sdk-go}@v0.18.0. Imports gofmt'd; go build ./... passes (grid-agent-gui: Go compiles, the frontend/dist embed is built by CI). Graph has no zosbase/tfgrid-sdk-go. Supersedes #19. Part of #2693.