Skip to content

Fix hang at end of camera firmware upload #525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thp merged 1 commit into from
Aug 5, 2026
Merged

Fix hang at end of camera firmware upload #525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/utils/ps4_camera_firmware.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,12 @@ Optional parameters:

libusb_free_device_list(devs, 1);

libusb_exit(usb_context);
// We would need to properly cleanup the libusb context, but since
// the device we keep opened goes away as part of the firmware upload,
// there are cases where libusb just hangs. Since ps4_camera_firmware_main()
// is only called from the CLI, and the process exits after returning from
// here, let's skip the cleanup and let the operating system take care of it.
//libusb_exit(usb_context);

return 0;
}
Loading