Skip to content

SCAL-310180 Added OpenSpotterVizPanel and CloseSpotterVizPanel spotterviz Host event#565

Merged
g-nitin-t merged 1 commit into
mainfrom
SCAL-310180
Jun 26, 2026
Merged

SCAL-310180 Added OpenSpotterVizPanel and CloseSpotterVizPanel spotterviz Host event#565
g-nitin-t merged 1 commit into
mainfrom
SCAL-310180

Conversation

@g-nitin-t

Copy link
Copy Markdown
Collaborator

No description provided.

@g-nitin-t g-nitin-t requested a review from a team as a code owner June 26, 2026 07:56

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds two new host events, OpenSpotterVizPanel and CloseSpotterVizPanel, to the HostEvent enum in src/types.ts to support opening and closing the SpotterViz panel. The accompanying JSDoc comments and examples are well-formatted and adhere to the repository's style guide. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@pkg-pr-new

pkg-pr-new Bot commented Jun 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@thoughtspot/visual-embed-sdk@565

commit: 11f74fe

@shivam-kumar-ts shivam-kumar-ts left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@g-nitin-t g-nitin-t merged commit 7e80ddf into main Jun 26, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants